[fix] Select Railway services when redeploying previews#4725
Open
mmabrouk wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThree Railway OSS hosting scripts are updated to pass ChangesExplicit Railway environment targeting for redeploys
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Railway preview deploys started failing after setup with
No deployment found for service. The deploy script checkedPostgresbut then ran a barerailway redeploy --yes, which depends on the CLI's currently linked service. The current Railway CLI exposes explicit--serviceselection and treats the old implicit service form as deprecated, so the bare redeploy can target a service with no deployment, such asgateway, before the script reaches Alembic or app deployment.Changes
Redeploy calls now pass the intended service and environment directly.
Before:
After:
The same explicit selector is used for the image-based preview deploy helper and smoke-test auto-repair paths, so no path relies on mutable Railway CLI service state for redeploys.
Tests / notes
bash -n hosting/railway/oss/scripts/deploy-from-images.sh hosting/railway/oss/scripts/deploy-services.sh hosting/railway/oss/scripts/smoke.shgit diff --check -- hosting/railway/oss/scripts/deploy-from-images.sh hosting/railway/oss/scripts/deploy-services.sh hosting/railway/oss/scripts/smoke.sh5.15.0.